Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code for parsing format that ginkgo tests emit #528

Merged
merged 3 commits into from
Oct 25, 2020
Merged

Add code for parsing format that ginkgo tests emit #528

merged 3 commits into from
Oct 25, 2020

Conversation

msabramo
Copy link
Contributor

@msabramo msabramo commented May 11, 2018 •
edited
Loading

@buzzdan
Copy link

buzzdan commented Jul 2, 2018

any news on that issue ?

@riannucci
Copy link
Collaborator

This needs to pass the tests first; I'd also love to see some new tests to cover this format.

@msabramo
Copy link
Contributor Author

I fixed the failing test by making the code be a little stricter about what it considers to be valid Ginkgo output.

@msabramo
Copy link
Contributor Author

I added some tests in 69af19f.

@amanhigh
Copy link

Can we merge this one. I love goconvey ui but want to make it work with ginkgo.

@riannucci riannucci merged commit 7827743 into smartystreets:master Oct 25, 2020
@riannucci
Copy link
Collaborator

Wow I really missed that test update...

@riannucci
Copy link
Collaborator

Sorry about the delay!

@msabramo msabramo deleted the process-ginkgo-results branch October 27, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

goconvey with ginkgo reports that passing tests fail.
4 participants
@msabramo @buzzdan @riannucci @amanhigh