Add proxy authentication for the HTTP client - Update HTTP client dependency #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
These changes should allow users to add a proxy server to the backup software. I got asked to do so because all our company's internet traffic is routet trough one. Maybe someone else could find it useful to have this option as well.
I'm aware that most of the code could have been written in a more clean and better way, as I myself am by no means a Java dev. If there is anything that you'd like to adjust or change feel free to do so :)
I'd be happy to see, that my addition was in some way, shape or form useful and looking forward to hearing from you!
Kind regards
Michael