Skip to content

Conversation

@m-ezzat
Copy link

@m-ezzat m-ezzat commented Mar 13, 2016

This pull request is focused on resolving occurrences of Sonar rule squid:S2974 - Classes without "public" constructors should be "final"

You can find more information about the issue here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S2974

Please let me know if you have any questions.

M-Ezzat

@m-ezzat
Copy link
Author

m-ezzat commented Jun 29, 2016

I am not sure whether you do not agree with these changes or not. Please close this PR if not.

@avioing
Copy link
Contributor

avioing commented Jul 1, 2016

mohamed - appreciate the PR. the backup tool is not an officially
supported deliverable, so we haven't had a chance to review your
submission. but will. thanks again!

On Tue, Jun 28, 2016 at 7:07 PM, Mohamed Ezzat notifications@github.com
wrote:

I am not sure whether you do not agree with these changes or not. Please
close this PR if not.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAG_ssv1tTChTs_vhG2HVvu0zlzoLWvaks5qQdNsgaJpZM4HvnrW
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants