-
Notifications
You must be signed in to change notification settings - Fork 62
gnupg-fpr-java #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tkrajesh
wants to merge
90
commits into
smartrevolution:master
Choose a base branch
from
guardianproject:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/ for products, etc.
…orking dep tracking
… gpg2 gpg2 is dynamically linked, and the only way in Android to find a dylib is via the LD_LIBRARY_PATH. Therefore, the gpg lib dir needs to be added for gpgme env as well.
I think this are only used for C++, but right now they are just another file to maintain while providing no benefit to us. They can be updated in the gnupg-for-java project once development settles down.
…ctor Before, it would only search and return public keys
Since ByteArrayOutputStreams are used to get data out of GnuPGData, add a size() method so that the ByteArrayOutputStream can pre-allocate the memory needed, or at least close to the final number.
… ones this should make it a tiny bit harder to sneak a bad .so into gnupg, and also avoid cases where people might install stuff willy-nilly on their device.
I want to be able to rapidly scan the methods and see how the args differ.
Currently, this needs stuff in the private gpgme header data.h, so we include it here for now. Ultimately this should be replaced by code that only uses the public API in gpgme.h
The headers are only useful during the implementation process, and are not needed during the build process. So make them a separate, optional step.
Running the original script made a lot of changes to the code, the edits to the script caused the least amount of changes for me.
This makes emacs automatically setup the right code formatting when it loads any of these files.
The same Makefile is now setup to handle multiple platforms. It currently works with Debian/Ubuntu/Mint/etc. and Windows with MinGW.
javah generates C headers from the Java sources, so they provide a way to check that the C JNI code matches the Java definitions. This commit enables that functionality.
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
|
Thanks |
KellySwaine
approved these changes
Dec 26, 2021
ghost
suggested changes
Apr 16, 2022
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
xximgeum
approved these changes
Jan 20, 2023
| jni/TAGS | ||
| # generated JNI headers | ||
| jni/com_freiheit_gnupg_GnuPG*.h | ||
| lib/libgnupg-for-java.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.