Issue #142 Improve performance of match any word --- Updated matchAnyWords and MatchAllWords to work with curried string o… #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perators opposed to regexps -- seems faster and more reliable on larger inputs. Also added new test cases
|
Thanks for the contribution! We're a bit swamped here trying to recover after the hurricane (our devs are mostly all based in south florida), but we'll get to this soon! |
|
@leftfields hi! Sorry for the super late response. Do you mind updating this branch? Once it's up to date, the code will be auto-formatted with prettier. After that we'll most likely merge it! |
|
@sadasant I don't think prettier will run for PRs from non-contirbutors 🤔 |
|
@daedalus28 I can make a copy of this changes, or what would be the better approach? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated matchAnyWords and MatchAllWords to work with curried string operators opposed to regexps -- seems faster and more reliable on larger inputs. Also added new test cases