Skip to content

Conversation

@leonhartX
Copy link
Member

The last version which introduced the usePrimitiveForNonNullField option has a bug, it will change all type to primitive if possible. 🙇

@leonhartX leonhartX requested review from kainoku and seratch April 24, 2019 01:35
Copy link

@kainoku kainoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonhartX leonhartX merged commit 26255aa into master Apr 24, 2019
@leonhartX leonhartX deleted the fix-nonnull-primitive branch April 24, 2019 01:45
@seratch
Copy link
Collaborator

seratch commented Apr 24, 2019

Okay. Will ship 0.99.7

@leonhartX
Copy link
Member Author

@seratch Thanks!

I've tried to run the release command but got some errors

./gradlew clean uploadArchives                                                                             ✔  5253  10:49:53
> Task :signArchives FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':signArchives'.
> Cannot perform signing task ':signArchives' because it has no configured signatory

seems I still need to do some prepare work(for the signing key and something else?)

@seratch
Copy link
Collaborator

seratch commented Apr 24, 2019

You need to set up gpg to work with https://docs.gradle.org/current/userguide/signing_plugin.html

@seratch
Copy link
Collaborator

seratch commented Apr 24, 2019

@leonhartX
Copy link
Member Author

Thanks for the quick response! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants