[ASQ-1255] De-deprecation of sms-fu and removal of deprecated Gem::Specification#has_rdoc #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelacunhadev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch was created off of the de-deprecate branch, created by Stone Filipczack, and which was previously used in the ASQ Gemfile - do we need to merge that branch first?
The change regarding the removal of
gem.has_rdoc = falsewas made when upgrading ASQ to Ruby 3.2 in the scope of the ticket ASQ-987, to address a deprecation warning like this:Motivation and Context
ASQ-1255 - Upgrade SmartLogic gems used in ASQ
ASQ-987 - Upgrade ASQ from Ruby 3.0 -> 3.2
Notes
I didn't create a separate PR for the
de-deprecatebranch, does that make a difference?Should we create a tag after merging this branch? If yes, what should the tag version look like?