Bugfix/webengine docker #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
Updates the Dockerfile to use the updated server code, including replacing the request library with built-ins. Also fixes an issue with AWS in how it sets up permissions for creating new buckets. The code now assumes you have a bucket already set up instead of trying to create one for you if it does not exist. For some reason the standard Node docker images were not working and also specifically node 16 had to be used for this. I just took the base debian image Node is typically built from and "manually" installed node and npm into the container.
To test the docker compose file make sure you edit the .yml file to change the VERSION argument to use this branch name instead of master as it will pull from this repository
VERSION=bugfix/webengine-dockerIf you have an existing policy server docker compose already set up from previous runs make sure you wipe everything out with
docker compose down -vfirst.