Skip to content

Fix SDLLockScreenActivityEspressoTest for newer devices#1877

Merged
joeygrover merged 3 commits intodevelopfrom
bugfix/issue_1876_fix_espresso_test
Dec 1, 2023
Merged

Fix SDLLockScreenActivityEspressoTest for newer devices#1877
joeygrover merged 3 commits intodevelopfrom
bugfix/issue_1876_fix_espresso_test

Conversation

@JulianKast
Copy link
Contributor

@JulianKast JulianKast commented Nov 30, 2023

Fixes #1876

This PR is [ready] for review.

Risk

This PR makes [major] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

All unit test were ran with this PR

Core Tests

i ran some basic test due to gradle changes connecting to a sync 3 tdk via Bluetooth and AOA

Core version / branch / commit hash / module tested against: Sync 3
HMI name / version / branch / commit hash / module tested against: Sync 3

Summary

This PR fixes an issue where SDLLockScreenActivityEspressoTest don't work on newer versions of android.

Changelog

Breaking Changes
  • To get the Espresso test to work, we had to update mockito dependencies, which forced us to update sourceCompatibility and targetCompatibility to JavaVersion.VERSION_1_8. It is highly unlikely that there are apps out there they have not already updated to at least Android 1.8 already.
Bug Fixes
  • Fix SDLLockScreenActivityEspressoTest test for newer devices

CLA

@joeygrover joeygrover merged commit cf9d01c into develop Dec 1, 2023
@joeygrover joeygrover deleted the bugfix/issue_1876_fix_espresso_test branch December 1, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants