Skip to content

Update integration validator with latest permissions and checks for exported #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulianKast merged 2 commits into from
Nov 29, 2023
Merged

Update integration validator with latest permissions and checks for exported #1875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81cb423
Add extra permissions to IntegrationValidator
joeygrover Nov 29, 2023
1eafb82
Add checks for exported SDL components
joeygrover Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions android/sdl_android/src/main/java/com/smartdevicelink/util/IntegrationValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,15 @@ private static ValidationResult checkPermissions(Context context) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) {
permissionList.add(Manifest.permission.FOREGROUND_SERVICE);
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
permissionList.add(Manifest.permission.BLUETOOTH_CONNECT);
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
permissionList.add(Manifest.permission.POST_NOTIFICATIONS);
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
permissionList.add(Manifest.permission.FOREGROUND_SERVICE_CONNECTED_DEVICE);
}
try {
PackageInfo packageInfo = context.getPackageManager().getPackageInfo(context.getApplicationContext().getPackageName(), PackageManager.GET_PERMISSIONS);
String[] permissionInfos = packageInfo.requestedPermissions;
Expand Down Expand Up @@ -161,6 +170,10 @@ public static ValidationResult checkBroadcastReceiver(Context context) {
int j = 0;
for (ResolveInfo sdlReceiver : sdlReceivers) {
if (receiver.name.equals(sdlReceiver.activityInfo.name)) {
if (!receiver.exported) {
retVal.successful = false;
retVal.resultText = "This application has not marked its SdlBroadcastReceiver as exported";
}
return retVal;
}
}
Expand All @@ -185,6 +198,11 @@ private static ValidationResult checkRoutServiceMetadata(Context context, Class
retVal.successful = false;
retVal.resultText = "This application has not specified its metadata tags for the SdlRouterService.";
}

if (!info.serviceInfo.exported) {
retVal.successful = false;
retVal.resultText = "This application has not marked its SdlRouterService as exported.";
}
} else {
retVal.successful = false;
retVal.resultText = "This application has not specified its SdlRouterService correctly in the manifest.";
Expand Down