Merged
Conversation
joeygrover
approved these changes
Oct 18, 2023
Member
|
Will target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1869
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
n/a
Core Tests
I tested manually setting the HashMap registerApps to null just before the spot where the NPE was hitting and connecting to a Sync 3 tdk.
Summary
This PR adds a null check in the RouterService to prevent an NPE from appearing for a partner app.
CLA