Bugfix/issue 1863 update gradle build variants for hello_sdl#1864
Merged
joeygrover merged 8 commits intodevelopfrom Oct 25, 2023
Merged
Bugfix/issue 1863 update gradle build variants for hello_sdl#1864joeygrover merged 8 commits intodevelopfrom
joeygrover merged 8 commits intodevelopfrom
Conversation
joeygrover
requested changes
Oct 24, 2023
Member
joeygrover
left a comment
There was a problem hiding this comment.
I don't think we need to add each of these items to the build flavors and they should be kept into the defaultConfig instead. They are all the same values for each of the flavors currently so it doesn't really make sense to have them in the individual flavors. If during development a dev wanted to make some flavors deploy different package/versions of the app for testing then they should be added ad hoc during that time; they would only need to add them to the specific flavor they want to use as a different package/app.
So this is what the defaultConfig should look like in my opinion (note I added SDL_ to the app name and ID keys):
defaultConfig {
applicationId "com.sdl.hellosdlandroid"
minSdkVersion 16
targetSdkVersion 33
versionCode 1
versionName "1.0"
resValue "string", "app_name", "Hello Sdl Android"
buildConfigField 'String', 'APP_TYPE', '"DEFAULT"'
buildConfigField 'String', 'REQUIRE_AUDIO_OUTPUT', '"FALSE"'
buildConfigField 'String', 'SDL_APP_NAME', '"Hello Sdl"'
buildConfigField 'String', 'SDL_APP_ID', '"8678309"'
manifestPlaceholders = [
appIcon: "@mipmap/ic_launcher"
]
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
}
joeygrover
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1863
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
n/a
Core Tests
I tested multiple apps including adding a new build variant to hello sdl and having multiple apps connect to sync.
Core version / branch / commit hash / module tested against: Sync 3
HMI name / version / branch / commit hash / module tested against: Sync 3
Summary
NOTE: Gradle PR must be reviewed first
This PR improves the build variants for hello sdl so we can test multiple versions of hello sdl by changing a few values or adding a new build variant.
CLA