Android 14 add package to PendingIntents in RouterService#1862
Merged
joeygrover merged 5 commits intodevelopfrom Nov 6, 2023
Merged
Android 14 add package to PendingIntents in RouterService#1862joeygrover merged 5 commits intodevelopfrom
joeygrover merged 5 commits intodevelopfrom
Conversation
joeygrover
requested changes
Nov 2, 2023
android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterService.java
Outdated
Show resolved
Hide resolved
joeygrover
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1861
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Unit Tests
n/a
Core Tests
Note: Before you install a second and thrid app, unplug the phone from the computer and switch the build variant before deploying app to the phone otherwise Android Studio will kill the app.
Or you can open each app up on the phone after deploying all three apps.
Test 1
Install 3 apps to the phone
Connect via Bluetooth to TDK
Observe all apps connect.
Test 2
Repeat test 1 but with release build versions of the apps.
Core version / branch / commit hash / module tested against: Sync 3
HMI name / version / branch / commit hash / module tested against: Sync 3
Summary
This PR adds a package to pending intents in the RouterService to prevent an exception from being thrown in the RouterService.
Changelog
Bug Fixes
CLA