Skip to content

Add sending messages to SdlRouterService to a new thread in TransportBroker #1851

Closed
JulianKast wants to merge 7 commits intodevelopfrom
bugfix/issue_1850_remove_sleep
Closed

Add sending messages to SdlRouterService to a new thread in TransportBroker #1851
JulianKast wants to merge 7 commits intodevelopfrom
bugfix/issue_1850_remove_sleep

Conversation

@JulianKast
Copy link
Contributor

@JulianKast JulianKast commented Jun 14, 2023

Fixes #1850

This PR is [ready] for review.

Risk

This PR makes [minor] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android

Unit Tests

I fixed broken test from changes made to the TransportBroker

Core Tests

Tested connecting apps to Sync 3. I tested that with a single app and multiple apps.
Tested multiple disconnects/reconnect attempts.

Sync 3

Summary

This Pr adds sending messages to SdlRouterService to be on a new thread via a custom task queuing system in the TransportBroker

Changelog

Bug Fixes
  • Fixes a potential bug where apps are crashing because of the sleep call in the TransportBroker

CLA

@JulianKast
Copy link
Contributor Author

Replaced by #1871

@JulianKast JulianKast closed this Oct 25, 2023
@joeygrover joeygrover deleted the bugfix/issue_1850_remove_sleep branch October 25, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant