Bugfix/issue #1842 - NPE in BaseTextAndGraphicsManager#1847
Merged
joeygrover merged 13 commits intodevelopfrom Jun 20, 2023
Merged
Bugfix/issue #1842 - NPE in BaseTextAndGraphicsManager#1847joeygrover merged 13 commits intodevelopfrom
joeygrover merged 13 commits intodevelopfrom
Conversation
…e in AlertManager
joeygrover
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1842
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Core Tests
Tested general functionality of each manager touched to ensure they still function.
Then when into each manager and set the
transactionQueueto null just before the null checks to ensure no crashes occurred, errors where logged, and callback listeners were triggered.I also tested setting the
FileManagertransactionQueueto null while trying other managers that rely on it.Tested Android Manticore v 2.11.0 and Sync 3
Tested JavaSE core 8.2.0 /sdl_hmi 5.8.0
Summary
This PR adds null checks to prevent NPE's with TaskMaster queues in the manager layers
Changelog
Bug Fixes
BaseTextAndGraphicManageras well as preventing it throughout the manager layerCLA