Hot Fix for #1839. Adding fallback logic for starting router service#1840
Hot Fix for #1839. Adding fallback logic for starting router service#1840joeygrover merged 6 commits intomasterfrom
Conversation
Does this include an increment of the sdl_router_service_version_value value? I noticed the RS version of 17 in the graphic, but still 16 in the sdl.xml file (I can manually adjust to 17 for testing if needed). |
RS version will remain 16. So yes, 17 was for testing only and was manually adjusted. Referenced comment is to update the version in the gradle file before merging as a hotfix. |
JulianKast
left a comment
There was a problem hiding this comment.
One formatting error, otherwise looks good, Do you want to update the version as well for the release?
android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlBroadcastReceiver.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Julian Kast <julian.kast@live.com>
Library used for testing has been updated and our integration is broken because of it. There is no play to fix this, so removing the tests for now from actions.
Fixes #1839
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Java SE, and Java EEUnit Tests
None added for this PR as the changes are not unit testable.
Core Tests
Tested with a Gen3 Ford TDK

Cycled through testing different permission allocations and who would start and ultimately host the router service.
Summary
Essentially added a new logical assumption that all apps need to be targeting Android 12 at this point and therefore require the user granted Nearby Devices permission to receive Bluetooth connection intents. Therefore, if an older version of the library is installed that does not have the newer permission check logic prior to start the RS, if that app does not have the correct permission we can assume they will not be receiving the BT ACL connection intent and we can ignore the old legacy logic that it would have executed.
We also added a fallback call to start the newest router service in the case there was an older SDL enabled app on the device but their integration was incorrect.
Changelog
Hot Fix
Tasks Remaining:
CLA