Update current screen data in T&G manager with template config#1834
Merged
JulianKast merged 5 commits intodevelopfrom Sep 21, 2022
Merged
Update current screen data in T&G manager with template config#1834JulianKast merged 5 commits intodevelopfrom
JulianKast merged 5 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1834 +/- ##
=============================================
+ Coverage 54.02% 54.05% +0.02%
- Complexity 5533 5537 +4
=============================================
Files 562 562
Lines 25862 25864 +2
Branches 3411 3412 +1
=============================================
+ Hits 13972 13980 +8
+ Misses 10610 10605 -5
+ Partials 1280 1279 -1
|
Contributor
|
Tested on Manticore and everything updates appropriately. Approved. |
ChloeMJM
approved these changes
Sep 20, 2022
# Conflicts: # android/sdl_android/src/androidTest/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperationTest.java
ChloeMJM
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1833
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Unit Tests
I updated existing unit test in TextAndGraphicUpdateOperationTest
Core Tests
Tested updating the template and check currentScreenData in BaseTextAndGraphicManager after the update.
Core version / branch / commit hash / module tested against: Manticore
HMI name / version / branch / commit hash / module tested against: Manticore
Summary
This PR adds a missing check in
TextAndGraphicUpdateOperationthat would check for a template config after an update and add that tocurrentScreenDatafor theTextAndGraphicManager.Changelog
Bug Fixes
TextAndGraphicUpdateOperationthat would check for a template config after an update and add that tocurrentScreenDatafor theTextAndGraphicManager.CLA