Bugfix/issue 1828 Good text failing

[ChloeMJM]

Fixes #1828

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

• I have verified that I have not introduced new warnings in this PR (or explain why below)
• I have run the unit tests with this PR
• I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
• I have tested Android, *Java SE, and *Java EE

Unit Tests

*Note: This branch has been tested for Android by Chloe, Julian Tested JavaSE

• testOnShowFailBadDataDoesNotUpdateScreen() : Tests the show failure branch within the sendShow method which notifies the currentScreenDataUpdateListener of an errorState.
• testUpdateTargetStateWithErrorStateNullDoesNotUpdateCurrentScreen(): Tests the updateTargetStateWithErrorState method to ensure that fields set to null will not be updated on the current screen.
• testUpdateTargetStateWithErrorBadDataDoesNotUpdateCurrentScreen() : Tests the updateTargetStateWithErrorState method to ensure that fields set to bad data will not be updated on the current screen.
• testUpdateTargetStateWithErrorBadDataAndGoodData() : Tests the updateTargetStateWithErrorState method to ensure that fields set to bad data will not be updated on the current screen but fields set with good data will be updated.

Core Tests

In Manticore verified that properties in screen manager when set would not fail when one attribute was given bad data

Summary

• In TextAndGraphicUpdateOperation: modified the sendShow method to call currentScreenDataUpdateListener.onError(updatedState) on failure.
• Modified the onError path of the currentScreenDataUpdateListener override to call updatePendingOperationsWithFailedScreenState(errorState), passing in an errorState.
• In BaseTextAndGraphicManager: added in method updatePendingOperationsWithFailedScreenState which sends the errorState to updateOperation.updateTargetStateWithErrorState(errorState)
• In TextAndGraphicUpdateOperation: added method updateTargetStateWithErrorState that ensures every field is null safe and compares the errorState to the updatedState. If they are the same, then it sets the updatedState to the currentScreenData associated with the field to keep the field from being updated with bad data.
• Added unit tests.

Changelog

Enhancements

• Screen data will update even if other fields may have bad data.

Bug Fixes

• Screen data will update even if other fields may have bad data.

Tasks Remaining

• Create fix.
• Add unit tests.
• Code review.

CLA

• I have signed the CLA

[codecov]

Codecov Report

Merging #1831 (c86d26d) into develop (b99a2ca) will decrease coverage by 0.01%.
The diff coverage is 54.23%.

@@              Coverage Diff              @@
##             develop    #1831      +/-   ##
=============================================
- Coverage      54.04%   54.02%   -0.02%     
- Complexity      5532     5534       +2     
=============================================
  Files            562      562              
  Lines          25821    25862      +41     
  Branches        3398     3411      +13     
=============================================
+ Hits           13954    13971      +17     
- Misses         10596    10610      +14     
- Partials        1271     1281      +10     

Impacted Files	Coverage Δ
...managers/screen/TextAndGraphicUpdateOperation.java	70.22% <48.48%> (-0.93%)	⬇️
...ink/managers/screen/BaseTextAndGraphicManager.java	63.29% <61.53%> (-0.88%)	⬇️
...smartdevicelink/encoder/VirtualDisplayEncoder.java	45.36% <0.00%> (-0.34%)	⬇️
...martdevicelink/transport/SdlBroadcastReceiver.java	3.02% <0.00%> (ø)
...tdevicelink/transport/SdlRouterStatusProvider.java	0.00% <0.00%> (ø)
...anagers/lifecycle/BaseSystemCapabilityManager.java	67.76% <0.00%> (+0.08%)	⬆️

[JulianKast]

First round code review

[JulianKast]

Don't stress about code coverage, given the design, it would require a lot of rewriting of current unit tests to get coverage in areas we did not have before to get to 60%