Prevent exceptions being thrown for remaining startForegroundService calls#1830
Merged
JulianKast merged 4 commits intodevelopfrom Sep 14, 2022
Merged
Prevent exceptions being thrown for remaining startForegroundService calls#1830JulianKast merged 4 commits intodevelopfrom
JulianKast merged 4 commits intodevelopfrom
Conversation
Update to protected to allow other transport classes to use it
Codecov Report
@@ Coverage Diff @@
## develop #1830 +/- ##
=============================================
+ Coverage 54.04% 54.16% +0.12%
- Complexity 5532 5569 +37
=============================================
Files 562 562
Lines 25821 25953 +132
Branches 3398 3459 +61
=============================================
+ Hits 13954 14058 +104
- Misses 10596 10614 +18
- Partials 1271 1281 +10
|
JulianKast
requested changes
Sep 13, 2022
android/sdl_android/src/main/java/com/smartdevicelink/transport/SdlRouterStatusProvider.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Julian Kast <julian.kast@live.com>
JulianKast
approved these changes
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1829
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Java SE, and Java EE(as this only affected Android classes)Unit Tests
N/A as these exceptions occur on random Android devices and are not easily reproducible outside of adding logic to make it happen.
Core Tests
N/A This only occurs because of Android having a bug when starting foreground services and isn't related to Core or the IVI directly.
Summary
Searched the project for any calls to
startForegroundServiceand surrounded them with a try/catch. If an exception occurs it is passed to a method to handle it by logging out the reason for the exception.Changelog
Bug Fixes
startForegroundServiceis called initially.CLA