Bugfix/issue 1802 Unregister apps when audio output becomes unavailable#1827
Merged
JulianKast merged 3 commits intodevelopfrom Sep 7, 2022
Merged
Bugfix/issue 1802 Unregister apps when audio output becomes unavailable#1827JulianKast merged 3 commits intodevelopfrom
JulianKast merged 3 commits intodevelopfrom
Conversation
Add to Andoroid’s SdlSession since it is only an Android feature
Closes LCM if audio outpput is required and no longer available. Properly clears apps off IVI.
Codecov Report
@@ Coverage Diff @@
## develop #1827 +/- ##
=============================================
- Coverage 54.04% 54.03% -0.01%
Complexity 5532 5532
=============================================
Files 562 562
Lines 25821 25821
Branches 3398 3398
=============================================
- Hits 13954 13953 -1
- Misses 10596 10597 +1
Partials 1271 1271
|
JulianKast
approved these changes
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1802
This PR is ready for review.
Risk
This PR makes no API changes.
Note: method added to library scoped class and therefore no API was added.
Testing Plan
Unit Tests
N/A These tests need to be ran manually.
CoreIVI TestsIVI Info: Sync Gen3
Summary
This PR addresses the issue of apps not unregistering when they require audio support, it is initially given, and then is removed. Previously it would stop the session but not unregister which on some IVIs means the app icon will still be visible to the user. These changes are the simplest in terms of scope and lowest of risk. The alternatives were either a little more messy or created a much larger risk across the entire Java Suite.
Alternatives:
Changelog
Bug Fixes
CLA