Fix formatting of many tables within the documentation#1810
Merged
noah-livio merged 18 commits intorelease/5.5.0_RCfrom Jun 28, 2022
Merged
Fix formatting of many tables within the documentation#1810noah-livio merged 18 commits intorelease/5.5.0_RCfrom
noah-livio merged 18 commits intorelease/5.5.0_RCfrom
Conversation
joeljfischer
suggested changes
Apr 21, 2022
base/src/main/java/com/smartdevicelink/proxy/rpc/Show copy.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## release/5.5.0_RC #1810 +/- ##
======================================================
- Coverage 54.37% 54.05% -0.32%
- Complexity 5498 5529 +31
======================================================
Files 562 562
Lines 25466 25809 +343
Branches 3317 3395 +78
======================================================
+ Hits 13847 13952 +105
- Misses 10360 10587 +227
- Partials 1259 1270 +11
|
Danielb287
approved these changes
May 28, 2022
joeljfischer
added
bug
noah-livio
suggested changes
Jun 27, 2022
Contributor
There was a problem hiding this comment.
The table formatting is improved and looks a lot better.
The code formatting is inconsistent across files overall and could use a full reformat and refactor in the future, but we'll have to ignore that for now.
I found a few things that do not match RPC Spec and I am able to leave comments for
base/src/main/java/com/smartdevicelink/proxy/rpc/AddSubMenu.java
Outdated
Show resolved
Hide resolved
noah-livio
suggested changes
Jun 28, 2022
base/src/main/java/com/smartdevicelink/proxy/rpc/BodyInformation.java
Outdated
Show resolved
Hide resolved
base/src/main/java/com/smartdevicelink/proxy/rpc/BodyInformation.java
Outdated
Show resolved
Hide resolved
base/src/main/java/com/smartdevicelink/proxy/rpc/BodyInformation.java
Outdated
Show resolved
Hide resolved
base/src/main/java/com/smartdevicelink/proxy/rpc/BodyInformation.java
Outdated
Show resolved
Hide resolved
Co-authored-by: noah-livio <95378272+noah-livio@users.noreply.github.com>
…on.java Co-authored-by: noah-livio <95378272+noah-livio@users.noreply.github.com>
…on.java Co-authored-by: noah-livio <95378272+noah-livio@users.noreply.github.com>
…on.java Co-authored-by: noah-livio <95378272+noah-livio@users.noreply.github.com>
…on.java Co-authored-by: noah-livio <95378272+noah-livio@users.noreply.github.com>
noah-livio
approved these changes
Jun 28, 2022
Contributor
noah-livio
left a comment
noah-livio
left a comment
There was a problem hiding this comment.
The tables look good and my requested changes have been implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1817
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Updates to the tables within the documentation can be reviewed in the below links on testing (note permission will be needed to view the testing site if you don't have it; please reach out to me):
Unit Tests
N/A
Core Tests
N/A
Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A
Summary
Fixing formatting of many tables within the documentation.
Changelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining: N/A
CLA