Fix auto restart video stream to ensure hmi level is streamable#1808
Merged
noah-livio merged 6 commits into5.4.0_RCfrom Apr 11, 2022
Merged
Fix auto restart video stream to ensure hmi level is streamable#1808noah-livio merged 6 commits into5.4.0_RCfrom
noah-livio merged 6 commits into5.4.0_RCfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.4.0_RC #1808 +/- ##
==============================================
- Coverage 54.05% 53.76% -0.30%
- Complexity 5519 5549 +30
==============================================
Files 562 562
Lines 25723 26060 +337
Branches 3372 3503 +131
==============================================
+ Hits 13904 14010 +106
- Misses 10562 10779 +217
- Partials 1257 1271 +14
|
…icitly released -- state may be leaked", So I modified logic to release it if we have already created EglCore object and are creating a new one
…form an HMI state that was not streamable to one that is.
…t change in Texture2dProgram
noah-livio
approved these changes
Apr 11, 2022
Contributor
noah-livio
left a comment
noah-livio
left a comment
There was a problem hiding this comment.
The code looks good and the fix works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1807
This PR is [ready] for review.
Risk
This PR makes [minor] API changes.
Testing Plan
Core Tests
Test:
Start a video stream to sdl_hmi
Using voice commands exit out of the app
Open app on HMI
Result:
You should be prompted by hmi to start streaming, click ok and video should stream.
Core 8.1 with sdl_hmi
Summary
Adds check to VideoStreamManager to check if HMI level is streamable before restarting video streaming, and added behavior for the stream to auto-restart when hmi is in a streamable state
Changelog
Bug Fixes
CLA