Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 5.4.0_RC #1806 +/- ##
===========================================
Coverage 54.05% 54.05%
+ Complexity 5519 5518 -1
===========================================
Files 562 562
Lines 25723 25723
Branches 3372 3372
===========================================
Hits 13904 13904
Misses 10562 10562
Partials 1257 1257
|
JulianKast
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1805
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
None added but existing Java SE unit tests ran successfully
Core Tests
N/A - This is unrelated to any interaction with Core, this issue is only related to Gradle sync and build
Summary
Replaces testCompile with testImplementation in build.gradle for sdl_java_se
Changelog
Breaking Changes
None
Enhancements
None
Bug Fixes
CLA