Add multiple checks to supportsSoftButtonImages()

[noah-livio]

Fixes #1800

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

• I have verified that I have not introduced new warnings in this PR (or explain why below)
• I have run the unit tests with this PR - N/A
• I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
• I have tested Android and Java SE

Unit Tests

N/A

Core Tests

On Core, I ran the following code in testBlank() of a local clone of sdl_test_suite_java and a modified local copy of sdl_java_suite in which PresentAlertOperation.supportSoftButtonImages() is public.

Test Code

AlertView.Builder builder = new AlertView.Builder();

        builder.setText("Test Alert");

        AlertView view = builder.build();

        //test null capability
        try {
            WindowCapability windowCapability = null;
            //WindowCapability windowCapability = new WindowCapability();
            //windowCapability.setSoftButtonCapabilities(Collections.emptyList());
            //windowCapability.setSoftButtonCapabilities(Collections.singletonList(null));

            PresentAlertOperation presentAlertOperation = new PresentAlertOperation(null, view,
                windowCapability, null, null, 0, new AlertCompletionListener() {
                @Override
                public void onComplete(boolean success, Integer tryAgainTime) {
                    if (success) {
                        messageLogger.logInfo(TAG, "Alert successful", true);
                    } else {
                        messageLogger.logError(TAG, "Alert failed", true);
                    }
                }
            }, null);

            messageLogger.logInfo(TAG,
                "Supports soft button images: " + presentAlertOperation.supportsSoftButtonImages(),
                true);
        } catch (Exception e) {
            messageLogger.logError(TAG, "Null capability crash", true);
        }

        //test null list
        try {
            //WindowCapability windowCapability = null;
            WindowCapability windowCapability = new WindowCapability();
            //windowCapability.setSoftButtonCapabilities(Collections.emptyList());
            //windowCapability.setSoftButtonCapabilities(Collections.singletonList(null));

            PresentAlertOperation presentAlertOperation = new PresentAlertOperation(null, view,
                windowCapability, null, null, 0, new AlertCompletionListener() {
                @Override
                public void onComplete(boolean success, Integer tryAgainTime) {
                    if (success) {
                        messageLogger.logInfo(TAG, "Alert successful", true);
                    } else {
                        messageLogger.logError(TAG, "Alert failed", true);
                    }
                }
            }, null);

            messageLogger.logInfo(TAG,
                "Supports soft button images: " + presentAlertOperation.supportsSoftButtonImages(),
                true);
        } catch (Exception e) {
            messageLogger.logError(TAG, "Null list crash", true);
        }

        //test empty list
        try {
            //WindowCapability windowCapability = null;
            WindowCapability windowCapability = new WindowCapability();
            windowCapability.setSoftButtonCapabilities(Collections.emptyList());
            //windowCapability.setSoftButtonCapabilities(Collections.singletonList(null));

            PresentAlertOperation presentAlertOperation = new PresentAlertOperation(null, view,
                windowCapability, null, null, 0, new AlertCompletionListener() {
                @Override
                public void onComplete(boolean success, Integer tryAgainTime) {
                    if (success) {
                        messageLogger.logInfo(TAG, "Alert successful", true);
                    } else {
                        messageLogger.logError(TAG, "Alert failed", true);
                    }
                }
            }, null);

            messageLogger.logInfo(TAG,
                "Supports soft button images: " + presentAlertOperation.supportsSoftButtonImages(),
                true);
        } catch (Exception e) {
            messageLogger.logError(TAG, "Empty list crash", true);
        }

        //test null button capability crash
        try {
            //WindowCapability windowCapability = null;
            WindowCapability windowCapability = new WindowCapability();
            //windowCapability.setSoftButtonCapabilities(Collections.emptyList());
            windowCapability.setSoftButtonCapabilities(Collections.singletonList(null));

            PresentAlertOperation presentAlertOperation = new PresentAlertOperation(null, view,
                windowCapability, null, null, 0, new AlertCompletionListener() {
                @Override
                public void onComplete(boolean success, Integer tryAgainTime) {
                    if (success) {
                        messageLogger.logInfo(TAG, "Alert successful", true);
                    } else {
                        messageLogger.logError(TAG, "Alert failed", true);
                    }
                }
            }, null);

            messageLogger.logInfo(TAG,
                "Supports soft button images: " + presentAlertOperation.supportsSoftButtonImages(),
                true);
        } catch (Exception e) {
            messageLogger.logError(TAG, "Null button capability crash", true);
        }

Core version / branch / commit hash / module tested against: Core release/8.1.0 b30f01258aeea4ec4c9cde22e942f091ade1cbfb
HMI name / version / branch / commit hash / module tested against: Generic HMI release/0.12.0 3ec306d2521f5151c215e4d98d9a230d6c544d6e

Summary

This PR adds null checks and a List.size() check to PresentAlertOperation.supportsSoftButtonImages(). These checks prevent crashes and returns true when soft button capabilities are unavailable. This new behavior improves alignment with the other SDL libraries.

Changelog

Breaking Changes

• None

Enhancements

• None

Bug Fixes

• Fixes Incorrect behavior and potential crashes in PresentAlertOperation.supportsSoftButtonImages() #1800

CLA

• I have signed the CLA

[codecov]

Codecov Report

Merging #1801 (1b9ea15) into 5.4.0_RC (a624a06) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##             5.4.0_RC    #1801      +/-   ##
==============================================
- Coverage       54.05%   54.04%   -0.02%     
  Complexity       5519     5519              
==============================================
  Files             562      562              
  Lines           25723    25728       +5     
  Branches         3372     3375       +3     
==============================================
  Hits            13904    13904              
- Misses          10562    10563       +1     
- Partials         1257     1261       +4     

Impacted Files	Coverage Δ
...icelink/managers/screen/PresentAlertOperation.java	55.94% <0.00%> (-1.27%)	⬇️
...nk/managers/audio/AudioDecoderCompatOperation.java	75.00% <0.00%> (-4.55%)	⬇️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java	52.43% <0.00%> (+2.43%)	⬆️