Make sure errorCode is not cut off#1791
Merged
JulianKast merged 1 commit intodevelopfrom Feb 24, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1791 +/- ##
=============================================
+ Coverage 54.32% 54.34% +0.01%
- Complexity 5520 5521 +1
=============================================
Files 562 562
Lines 25592 25590 -2
Branches 3339 3338 -1
=============================================
+ Hits 13904 13906 +2
+ Misses 10426 10424 -2
+ Partials 1262 1260 -2
|
noah-livio
approved these changes
Feb 24, 2022
Contributor
noah-livio
left a comment
noah-livio
left a comment
There was a problem hiding this comment.
The fix works as expected and the code looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1790
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
N/A
Core Tests
Attempt to test Encrypted Video Streaming using an app with the app ID wrong_app_id and the default security lib
Observe this log when Encrypted Video Stream Fails
Security Query module internal error: INVALID_CERT
Core version / branch / commit hash / module tested against: release/8.1.0
HMI name / version / branch / commit hash / module tested against: Generic HMI release/0.12.0
Summary
There was a condition where we were cutting the bulk short by 1 byte. This should not happen so that condition was removed and the bulkdata will now be set to the appropriate size.
CLA