Add timeout units to Javadoc comments#1778
Merged
bilal-alsharifi merged 2 commits intosmartdevicelink:developfrom Jan 6, 2022
Merged
Add timeout units to Javadoc comments#1778bilal-alsharifi merged 2 commits intosmartdevicelink:developfrom
bilal-alsharifi merged 2 commits intosmartdevicelink:developfrom
Conversation
bilal-alsharifi
suggested changes
Jan 6, 2022
Contributor
bilal-alsharifi
left a comment
bilal-alsharifi
left a comment
There was a problem hiding this comment.
It seems that the Slider RPC is also missing timeout unit
Contributor
Author
|
Fixes #1775 This PR is ready for review. RiskThis PR makes no API changes. Testing Plan
Unit TestsN/A - This PR only changes documentation, not runnable code. Core TestsN/A - This PR only changes documentation, not runnable code. Core version / branch / commit hash / module tested against: N/A SummaryThis PR adds the units (milliseconds) to the Javadoc comments related to timeouts in ChangelogBreaking Changes
Enhancements
Bug FixesTasks Remaining:
CLA
|
Codecov Report
@@ Coverage Diff @@
## develop #1778 +/- ##
=============================================
- Coverage 54.36% 54.33% -0.04%
+ Complexity 5509 5507 -2
=============================================
Files 562 562
Lines 25516 25516
Branches 3319 3319
=============================================
- Hits 13873 13865 -8
- Misses 10384 10392 +8
Partials 1259 1259
|
bilal-alsharifi
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1775
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
N/A - This PR only changes documentation, not runnable code.
Core Tests
N/A - This PR only changes documentation, not runnable code.
Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A
Summary
This PR adds the units (milliseconds) to the Javadoc comments related to timeouts in
ScrollableMessageChangelog
Breaking Changes
Enhancements
Bug Fixes
Tasks Remaining:
CLA