Skip to content

Fix for issue 1751: fixes a crasher when running on Android 12#1752

Closed
shiniwat wants to merge 1 commit intosmartdevicelink:release/5.3.0_RCfrom
shiniwat:bugfix/issue-1751
Closed

Fix for issue 1751: fixes a crasher when running on Android 12#1752
shiniwat wants to merge 1 commit intosmartdevicelink:release/5.3.0_RCfrom
shiniwat:bugfix/issue-1751

Conversation

@shiniwat
Copy link
Contributor

Fixes #1751

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

I have run SdlRouterServiceTests.

Core Tests

n/a

Core version / branch / commit hash / module tested against: 7.0
HMI name / version / branch / commit hash / module tested against: our own HMI test suite

Summary

This fixes a crasher when SDL app sets targetSdkVersion to 31, and running on Android 12.

Changelog

Breaking Changes
  • n/a
Enhancements
  • n/a
Bug Fixes

Tasks Remaining:

  • n/a

CLA

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #1752 (d8fa5ca) into release/5.3.0_RC (6023082) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             release/5.3.0_RC    #1752      +/-   ##
======================================================
- Coverage               54.40%   54.39%   -0.02%     
+ Complexity               5504     5499       -5     
======================================================
  Files                     562      562              
  Lines                   25459    25460       +1     
  Branches                 3315     3316       +1     
======================================================
- Hits                    13851    13848       -3     
- Misses                  10352    10357       +5     
+ Partials                 1256     1255       -1     
Impacted Files Coverage Δ
...om/smartdevicelink/transport/SdlRouterService.java 11.09% <0.00%> (-0.01%) ⬇️
...agers/screen/menu/VoiceCommandUpdateOperation.java 76.37% <0.00%> (-2.37%) ⬇️
...ink/managers/screen/BaseTextAndGraphicManager.java 64.16% <0.00%> (-0.42%) ⬇️
...managers/screen/TextAndGraphicUpdateOperation.java 71.15% <0.00%> (-0.28%) ⬇️
...com/smartdevicelink/util/MediaStreamingStatus.java 64.76% <0.00%> (+0.95%) ⬆️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (+1.21%) ⬆️

@joeygrover
Copy link
Member

Included in #1771

@joeygrover joeygrover closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants