Revise SDL 0338 - Remove Unused Files From SDL Core

[Jack-Byrne]

Introduction

This is a revision to an accepted proposal. The revision is to remove more files from SDL Core that were found to be unused.

Motivation

The author missed some unused files that should have been included in original proposal. These files were pointed out by a contributor in this comment.

Proposed Solution

Include the following files to be removed from the SDL Core Project in addition to the files named in the original proposal:

• on_vi_body_information_notification.cc
• on_vi_device_status_notification.cc
• on_vi_driver_braking_notification.cc
• on_vi_engine_torque_notification.cc
• on_vi_external_temperature_notification.cc
• on_vi_fuel_level_notification.cc
• on_vi_fuel_level_state_notification.cc
• on_vi_gps_data_notification.cc
• on_vi_head_lamp_status_notification.cc
• on_vi_instant_fuel_consumption_notification.cc
• on_vi_my_key_notification.cc
• on_vi_odometer_notification.cc
• on_vi_prndl_notification.cc
• on_vi_rpm_notification.cc
• on_vi_speed_notification.cc
• on_vi_steering_wheel_angle_notification.cc
• on_vi_tire_pressure_notification.cc
• on_vi_vin_notification.cc
• on_vi_wiper_status_notification.cc
• on_vi_body_information_notification.h
• on_vi_device_status_notification.h
• on_vi_driver_braking_notification.h
• on_vi_engine_torque_notification.h
• on_vi_external_temperature_notification.h
• on_vi_fuel_level_notification.h
• on_vi_fuel_level_state_notification.h
• on_vi_gps_data_notification.h
• on_vi_head_lamp_status_notification.h
• on_vi_instant_fuel_consumption_notification.h
• on_vi_my_key_notification.h
• on_vi_odometer_notification.h
• on_vi_prndl_notification.h
• on_vi_rpm_notification.h
• on_vi_speed_notification.h
• on_vi_steering_wheel_angle_notification.h
• on_vi_tire_pressure_notification.h
• on_vi_vin_notification.h
• on_vi_wiper_status_notification.h

Potential Downsides

The author does not see any potential downsides that weren't already addressed in the original proposal.

Impact On Existing Code

Unused files will be removed from SDL Core.

Alternatives Considered

The alternative would be to completely revert the original proposal.

[Jack-Byrne]

@theresalech Ready for review

[theresalech]

@JackLivio can you please add the Alternatives Considered section to the PR description? Thank you!