Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new SDL system Structure using Mediation Application for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models #1132

Merged
merged 34 commits into from
Apr 28, 2021
Merged

Add new SDL system Structure using Mediation Application for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models #1132

merged 34 commits into from
Apr 28, 2021

Conversation

Akihiro-Miyazaki
Copy link
Contributor

Introduction

This proposal is to construct new SDL system for a Head Unit(HU) with low performed ECU for Powered Two Wheeler (PTW) *1 middle/low-end class models and low-cost vehicle models.

*1 Powered Two Wheeler (PTW) includes motorcycle/scooter/moped.

unknown added 2 commits April 21, 2021 13:28
Create the proposal of Add new SDL system Structure using Mediation A…
53b2336 
…pplication for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models
Add the image files of Add new SDL system Structure using Mediation A…
1e9be99 
…pplication for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models
@Akihiro-Miyazaki
Copy link
Contributor Author

Hi. @jordynmackool -san
This proposal is for Powered Two Wheels(PTW).
Could you please review my proposal?
Thank you!

@jordynmackool
Copy link
Contributor

Hi @Akihiro-Miyazaki, thanks for tagging Livio for a review. @theresalech will review this PR when her time allows. Thanks!

@Akihiro-Miyazaki
Copy link
Contributor Author

Hi, @jordynmackool -san
Thank you for your comment.
I'm waiting for theresalech sans advice.

Hi, @theresalech -san,
I'm glad to see you again.
Could you please review my proposal?
Thank you!

theresalech
theresalech requested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Akihiro-Miyazaki , I've completed my initial review. Please see my comments and let me know if you have any questions or concerns with addressing. Thank you!

proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
Akihiro-Miyazaki and others added 24 commits April 23, 2021 09:18
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
fffeac6 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
4b1e1dd 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
7079bcb 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
37ec2f8 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
baf2d8e 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
039fa1d 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
96a6179 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
f0f3a64 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
f50db34 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
8157e8f 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
f395b90 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
0c4131b 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
8e1a2a1 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
bff6615 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
9f7d32d 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
4da47a9 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
1fe0db6 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
488e15c 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
0c880cf 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
f2c1a57 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
630fe2c 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
aa435fb 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
b047834 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
3615e35 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
Akihiro-Miyazaki and others added 4 commits April 23, 2021 09:34
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
77d2509 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
c3f183f 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
6ee1af4 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
18238f7 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
@Akihiro-Miyazaki
Copy link
Contributor Author

Akihiro-Miyazaki commented Apr 23, 2021 •
edited
Loading

Hi, @theresalech -san,
Thank you for your advice and comments.
We approved almost of your suggestion.
And we left our comments about all your comments.
Please confirm them.
Thank you.

Modify the proposal of Add new SDL system Structure using Mediation A…
59aaa81 
…pplication for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models
@Akihiro-Miyazaki
Copy link
Contributor Author

Hi, @theresalech -san,
Thank you for your cooperation as always.
We updated the proposal documentation according to our comments above and made a commit it.
Could you please confirm them.
Thank you.

theresalech
theresalech requested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@theresalech theresalech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akihiro-Miyazaki -san, thank you for your updates! I have left a few additional comments, based on your responses and changes to the proposal. Please let me know if you have any questions or concerns. Thanks!

proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Application.md Outdated Show resolved Hide resolved
Akihiro-Miyazaki and others added 3 commits April 27, 2021 09:41
@Akihiro-Miyazaki @theresalech
Update proposals/NNNN-Add-new-SDL-System-Structure-using-Mediation-Ap…
0fd8542 
…plication.md

Co-authored-by: theresalech <theresa@livio.io>
Modify the proposal of Add new SDL system Structure using Mediation A…
e43de94 
…pplication for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models
Modify the proposal of Add new SDL system Structure using Mediation A…
ffb439b 
…pplication for Middle/Low-end Class Model of Powered Two Wheeler and low-cost vehicle models
@Akihiro-Miyazaki
Copy link
Contributor Author

Hi, @theresalech -san,
Thank you for your cooperation as always.
I committed all your suggestion.
Could you please confirm them.
Thank you in advance for your help.

@theresalech theresalech merged commit ee19cdf into smartdevicelink:master Apr 28, 2021
@Akihiro-Miyazaki Akihiro-Miyazaki deleted the sdl_system_structure_for_powered_two_wheels branch May 6, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theresalech theresalech theresalech approved these changes

Assignees
No one assigned
Labels
hmi ios java suite javascript review ready rpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Akihiro-Miyazaki @jordynmackool @theresalech