-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise SDL-0329 OnDataResumed Notification #1129
Merged
jordynmackool
merged 5 commits into
smartdevicelink:master
from
Jack-Byrne:revisions/sdl-0329-OnDataResumed-Notification
Mar 31, 2021
Merged
Revise SDL-0329 OnDataResumed Notification #1129
jordynmackool
merged 5 commits into
smartdevicelink:master
from
Jack-Byrne:revisions/sdl-0329-OnDataResumed-Notification
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jordynmackool Ready for review |
jordynmackool
requested changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JackLivio, I have completed my review, please see my requested changes and let me know if you have any questions. Thanks!
Co-authored-by: Jordyn Mackool <42153846+jordynmackool@users.noreply.github.com>
@jordynmackool Ready for review |
jordynmackool
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This revises SDL 0329 according to the reviewed comments when this proposal was first created. Original discussion can be found here
Motivation
Revision summarized from SDLC review can be found in this comment
Proposed solution
Reduce the verbosity of the OnDataResumed notification. Instead of sending all resumed data back to the app, simply respond if the resumed data was successfully resumed or not.
If the app did not use a particular resumption data item, that value will be omitted from the notification. For example if an app resumes and was not using Remote Control subscriptions, the
remoteControlSubscriptionsResumed
parameter would be omitted.Potential Downsides
Proposal does not alter the behavior of SDL Core to allow for partial resumption.
Alternatives considered
An alternate solution would be to include this information in the RegisterAppInterface Response since the resumption state is known before SDL Core sends the RegisterAppInterfaceResponse to an app. The author did not choose this path due to the current size of the RegisterAppInterFace response.
Other alternates considered would be to change this notification to a request so an app can request this info when necessary, or to implement a more robust resumption manager into the App Library.