-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accepted with Revisions] SDL 0148 - Template Improvements: Additional SubMenus #423
Comments
👍 I believe the DriverDistractionCapability struct will be useful in the future if expanded for other types of limitations in addition to sub menu depth. |
I have three topics for this: Combined proposalThis seems like two proposals.
I support both, but wonder if we want to split for clarity. Default list itemSecondly, Carplay automatically adds a button to the bottom of the list if the list is restricted due to driver distraction. This button usually initializes some kind of Voice Interaction. I wonder if we want to allow a new flag for Bulk addcommandsCurrently it is pretty cumbersome to create these menu structures, especially for large list, when doing one addCommand at a time. I wonder if we want make this easier for app developers. Either by having a function in the proxy that accepts an object and sends the single rpc's or by allowing some kind of bulk uploading. |
Hi @tpulatha a few notes
I think a default list item is a good idea. I do wonder about implementation, however. I think Core / HMI automatically adding a list item at the bottom that starts a voice search for that list might be the best solution than a mobile / developer driven solution. So if you're in a list "Artists" then HMI would automatically have a list item at the bottom "Search Artists" which would start a voice session for the user to speak the name of an item in the list. Alternately, because the VR sequences can take so long to compile, if we don't have VR for that list it would say something like "Truncated for Safety".
In the latest proxy versions, there will be an addition to send multiple RPCs in one go. You still have to create each of the commands, but then you can pack them up in an array and send them. That will help, I'm not sure what more we can do without a new RPC. |
When talking about truncate do you mean to limit the list to the first n items? CarPlay shrinks most of the lists to the recently used items. The additional item added to the end to start VR does that button open a VR session for the app or only for those in the current sub menu? |
@kshala-ford The idea would be for those in the current sub-menu. |
@kshala-ford Carplay does not necessarily only shrink to recently used, they also shrink playlists or artist lists. @joeljfischer I think a fixed VR functionality would miss a use case where an App has its own VR engine and might want to start something like an Alexa or Cortana interaction |
The Steering Committee has voted to accept this proposal with the following revisions: update proposal to only include details regarding "Allowing Submenu's with parentID's that refer another Submenu." A separate proposal will be entered to discuss "Allowing Core to define driver distraction parameters for HMI." When discussing submenus, a few additional points were made:
|
@joeljfischer please advise when a new PR has been entered to update the proposal to reflect the agreed upon revisions. I'll then merge the PR so the proposal is up to date, and enter issues in the respective repositories for implementation. Thanks! |
Proposal has been revised to reflect revisions, and issues have been entered: |
Hello SDL community,
The review of "Template Improvements: Additional SubMenus'" begins now and runs through March 13, 2018. The proposal is available here:
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0148-template-additional-submenus.md
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
#423
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Theresa Lech
Program Manager - Livio
theresa@livio.io
The text was updated successfully, but these errors were encountered: