-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Withdrawn] SDL 0324 - Function to control the priority of audio and video when switching between apps #1095
Comments
1. The motivation of this proposal is not at all clear. Uncommon terminology like "app status transition rule" is used and not defined. Please define your terms and provide examples. Despite reading this proposal I don't know what problem it's solving. I have additional points, but this proposal is, in my opinion, un-reviewable until the above is fixed. |
Also I agree the motivation needs to be updated. Motivation should explain what problem this proposal solves.
I don't agree with creating two separate configuration files for this feature. Any SDL Core customizations should be added to the existing smartDeviceLink.ini configuration file.
|
@joeljfischer -san, For this reason, we define the rules for the app status transition such as "only one app can be FULL at a time", we propose to add a function in which OEMs can set the priority control of audio and video according to the rules of status transition. Currently, the app behavior of when app switches is implemented in SDL Core, so it does not work as OEM intended. If our reply above is not answered to the intention of your comment, could you please explicitly show us the details. @JackLivio -san, We would like to reply No.3-5 comments, after they are in focus on each other in this matter. Thank you for your advice. Thank you. |
The Steering Committee voted to keep this proposal in review on 2020-11-24 to allow for conversation to continue on the review issue. |
1.
I'm sorry, but I'm still struggling to understand this sentence. Do you mean something like, "we propose to add the ability to configure the rules SDL Core uses to change connected apps' video and audio HMI statuses?" |
@joeljfischer -san, If an app is launched during other app was launched, the rules such as which app is audible or which app is streamable and etc. are already implemented by SDL Core. To be able to modify the rules by the OEMs themselves, I would like to move the rules to policy table. |
1. Thanks for the response, I think I understand what you are attempting to do with this proposal. I believe that the motivation needs to be made clearer in order to help others understand the problem that you are attempting to solve. |
|
To ensure all open items are addressed and make the comments easier to follow, please respond to the open items in one comment moving forward. To provide clarity of the current status of this proposal review, please see a summary of the items below: Author to respond to the following open items:
Agreed upon revisions:
|
The Steering Committee voted to keep this proposal in review on 2020-12-01 to allow for the author to respond to the remaining open items, summarized in this comment. |
i) How should this table be represented in the smartDeviceLink.ini file? ii) I think the iii) The table does not include the impact of OnEventChanged notifications from the HMI. i) I am not sure how it will reduce the processing load of SDL Core? What do you imagine the implementation of the sdl core state manager would like like to accomplish this? ii) My concern is with the number of testable cases that will be needed by allowing customization of these options. 25 app type combinations * 4 App1 HMI level options * 3 App1 Audible options * 4 App2 HMI level options * 3 App2 Audible options = 3600 possible configurations for this feature. There are probably more combinations since OnEventChanged notifications are not included in the table. Testing that this feature's behavior is true its configuration will be difficult. IMO allowing the customization of these fields will reduce the reliability of SDL's OnHMIStatus message. I still would like to see a specific use case on why customizing these fields would be beneficial. What about the current behavior is not working for the authors integration? |
@JackLivio -san, 3ii 3iii 4i 4ii We think by clarifying, the behavior becomes easy to visible. 5 |
3i) Thank you, but I would like to see the .ini entries included in the proposal. See how ini updates were included in this proposal 3ii) 👍 3iii) This proposal has a chart that includes documented behavior for OnEventStatus Picture of chart for reference: OnEventChanged is a message sent by the HMI to let Core know when a native functionality of the HMI overrides what an SDL App might be doing. For example taking a phone call, switching to cd/radio, started embedded navigation will affect an App's HMI level, streamable, and audible statuses. How these events are handled should be mentioned in the proposal. Does the author wish to customize these events?
Maybe there is an easier way to accomplish a solution instead of completely changing Core's hmi state logic with a high resolution configuration. Also, is the issue only with the rules for audible & streamable? |
The Steering Committee voted to keep this proposal in review on 2020-12-08 to allow for conversation to continue on the review issue. |
@JackLivio -san,
If you have idea better than ours, could you please teach us? 3iii) Also, I think that the control (handle) between SDL and HU is supported on the HU side. |
@JackLivio -san, |
Please respond to all open items in one comment moving forward. To provide clarity of the current status of this proposal review, please see a summary of the items below: Open Items: 3i.[Nexty] Thank you, but I would like to see the .ini entries included in the proposal. See how ini updates were included in this proposal. 3iii. [Nexty] Thank you for your explanation. We understood. 5. [Nexty] I'm very sorry for this comment, but there is no specific example. However, we believe that OEMs have specifications that require audible and streamable output in each case. Therefore, it would be useful if the OEM could customize it. Agreed upon revisions: 1. Author to update the Motivation to explain what problem this proposal is solving. 3. Examples of the configurations need to be added to the proposal. Examples should include key/values for configurations.
2. See 2 in this comment - Add configurations to the ini file instead of policies. Resolved, no action need: 4, 4i, 4ii |
i) Thank you for this. Will consider review after discussion from number 5. iii) I would request that a note be added in the proposal that OnEventChange request hmistatus outcomes will use not be altered by these the customizations.
I don't think it is necessary to add detailed customization for all app types, hmi levels, and streaming states. I think the desired outcome could be resolved by a single configuration. smartDeviceLink.ini:
|
The Steering Committee voted to keep this proposal in review on 2020-12-15 to allow for the conversation to continue on the open items, summarized in this comment. |
@JackLivio -san, 3i. 3iii. In this proposal, it describes which app's audible and streamable are selected in the SDL system. Does this comment match your requirement? Thank you for your suggestion.
Our proposal: the navigation app1 moves to Background and not audible and not streamable. |
3i. I am sorry but I think the example table provided for the .ini config is not very readable and would be error prone. I am still trying to understand why all of these items need customizations. Continued in number 5. 3ii. 👍
If you are proposing these changes without a reason for how customizing these options would be helpful, I will not be able to endorse this proposal. I do not see a reason for making large changes to the SDL Core code to implement a customizable table that is envisioned to keep the same behavior. |
@JackLivio -san, 3ii. Currently, as SDL, which screen is prioritized and which audio is prioritized when an app switches other app is implemented in SDL Core, but I assume that it does not define explicitly. |
3i). Blocked by discussion number 5. 3iii). Yes sorry I meant 3iii. 👍 .
I am sorry but I do not see the merit in customizing app switching behavior.
We already have HMI RPC's that tell Core what context the app is being shown in by the HMI: Show an app -> OnAppActivated |
@JackLivio -san,
We know these HMI RPC. |
|
To provide clarity of the current status of this proposal review, please see a summary of the items below: Open Items: 3i. Blocked by 5. 5. See comment here. Agreed upon revisions: 1. Author to update the Motivation to explain what problem this proposal is solving. 2. See 2 in this comment - Add configurations to the ini file instead of policies. 3. Examples of the configurations need to be added to the proposal. Examples should include key/values for configurations.
Resolved, no action need: 4, 4i, 4ii |
As the author has requested additional time to respond to open item number 5 in this comment, which is blocking the other remaining open item (3i). The project maintainer suggests deferring this proposal to allow other review issues to be brought into review. |
The Steering Committee voted to defer this proposal on 2021-01-12 to allow the author additional time to respond to the open items summarized in this comment. The proposal will remain deferred until the author has acknowledged (via email to sdlc@smartdevicelink.com) that they are ready to respond. |
This proposal has been withdrawn per the author's request via email. |
Hello SDL community,
The review of "SDL 0324 - Function to control the priority of audio and video when switching between apps" began on November 18, 2020, and continues through January 12, 2021. The proposal is available here:
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0324-Function-to-control-the-priority-of-audio-and-video-when-switching-between-apps.md
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
#1095
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Jordyn Mackool
Program Manager - Livio
Jordyn@livio.io
The text was updated successfully, but these errors were encountered: