[SDL 0238] Scripts for Keyboard Enhancements feature
#2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashwink11, please review this PR. |
|
@KhrystynaDubovyk changes approved from the Ford side. |
|
@JackLivio This PR is ready for Livio ready. Thank you! |
|
@jordynmackool this PR is ready for review. Thanks! |
jacobkeeler
requested changes
Jan 25, 2021
...s/API/KeyboardEnhancements/Capabilities/006_SDL_populates_numConfigurableKeys_with_zeros.lua
Outdated
Show resolved
Hide resolved
...ts/Capabilities/001_HMI_provides_valid_values_for_all_parameters_in_KeyboardCapabilities.lua
Outdated
Show resolved
Hide resolved
...ts/API/KeyboardEnhancements/SetGlobalProperties/005_App_defines_customizeKeys_edge_cases.lua
Outdated
Show resolved
Hide resolved
.../KeyboardEnhancements/SetGlobalProperties/006_App_defines_invalid_value_in_customizeKeys.lua
Outdated
Show resolved
Hide resolved
...nts/SetGlobalProperties/008_App_defines_not_supported_special_character_in_customizeKeys.lua
Outdated
Show resolved
Hide resolved
|
@jacobkeeler, all comments are addressed. |
|
d2ad6d0 fixes a typo in the function name. |
|
@jacobkeeler Please notice all updates related to revision are done and PR is ready for review. Thank you! |
jacobkeeler
requested changes
Feb 9, 2021
jacobkeeler
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATF Test Scripts to check #2970
This PR is [ready] for review.
Summary
New scripts for the
Keyboard EnhancementsfeatureATF version
feature/7.1.0_version_bump
Changelog
CLA