Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script update for 2479 issue #2423

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Conversation

dboltovskyi
Copy link
Contributor

@dboltovskyi dboltovskyi commented Jun 11, 2020

Fix for #2366

This PR is [ready] for review.

Summary

Fix for the issue

ATF version

develop

Changelog

  • Script is reworked according to the latest changes in core

CLA

@@ -1,5 +1,5 @@
---------------------------------------------------------------------------------------------------
-- User story: https://github.com/smartdevicelink/sdl_core/issues/2379
-- User story: https://github.com/smartdevicelink/sdl_core/issues/2479
--
-- Description:
-- 1) SDL does not respond ACK on second service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description according to an actual sequence in the script(SDL does respond with ACK)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GetmanetsIrina Description is updated in cf6f03e

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dboltovskyi, thank you for the update.

@dboltovskyi dboltovskyi marked this pull request as ready for review October 28, 2020 19:05
@dboltovskyi dboltovskyi force-pushed the fix/update_script_for_2479_issue branch 2 times, most recently from f3c8365 to 9fe971b Compare October 28, 2020 20:11
@iCollin iCollin merged commit 4ef3650 into develop Nov 5, 2020
@iCollin iCollin deleted the fix/update_script_for_2479_issue branch November 5, 2020 20:57
@dboltovskyi dboltovskyi mentioned this pull request Apr 21, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants