Feature/Remote Control - Radio and Climate Parameter Update

[LuxoftAKutsan]

ATF Test Scripts to check smartdevicelink/sdl_core#2793

This PR is ready for review.

Summary

This proposal changes the minimum index of HD radio sub-channels from 1 to 0.
In addition, we propose to add a new parameter climateEnable to ClimateControlData which will allow an application to power climate control on or off.

ATF version

develop (checked on smartdevicelink/sdl_atf@109d1cb)

CLA

• I have signed the CLA

[yang1070]

Ford has reviewed, run the test scripts and approved this PR.

[Jack-Byrne]

I am not familiar with this syntax. Does this overwrite the definition of the common getAnotherModuleControlData()?

[dboltovskyi]

@JackLivio Correct. When notificationProcessedSuccessfully() function is executed implementation of commonRC.getAnotherModuleControlData() will be overwritten. And new code will be used till the end of the script.

[Jack-Byrne]

Saw a failure with this test ./test_scripts/RC/CLIMATE_RADIO/SetInteriorVehicleData/023_availableHDs_hdChannel_out_of_upper_bound.lua

[13:12:16,168] SetInteriorVehicleData_set_incorrect_values_for_hdChannel_as_outOfLowerBoundValue     [FAIL] (10050 ms)
 Response to 5: ValidIf: 
payload.resultCode: expected: INVALID_DATA, actual value: GENERIC_ERROR
 HMI call RC.SetInteriorVehicleData: Times: The most allowed occurences boundary exceed

Looking into the cause.

[Jack-Byrne]

I believe that the test is sending a 0 as a lower out of bound value and the test is expecting it to fail. However the changes for this feature should allow 0 to be sent for an hdChannel.

[Jack-Byrne]

Note i updated the syncMessage version of the apps in the config.lua to 6.0 before running the tests.

[dboltovskyi]

@JackLivio
Thank you for this finding.
Unfortunately last commit Update regarding changed min value for hdChannels was made by mistake.
It changed min value for hdChannel parameter to 1 though it should be 0 as before.

Now this commit is removed and additionally PR is re-based onto HEAD of develop.
We also found inconsistency between MOBILE and HMI APIs regarding hdChannel parameter which is fixed in smartdevicelink/sdl_core@0099496

[Jack-Byrne]

@dboltovskyi Thank you, re-running tests now.