Add PTU check for allow_unknown_rpc_passthrough #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShobhitAd
requested changes
Apr 9, 2019
test_scripts/AppServices/RPCPassThrough/005_PTU_allow_unknown_rpc_passthrough.lua
Outdated
Show resolved
Hide resolved
ShobhitAd
requested changes
Apr 9, 2019
| --------------------------------------------------------------------------------------------------- | ||
| -- Precondition: | ||
| -- 1) app1, app2 and app3 are registered on SDL. | ||
| -- 2) AppServiceProvider permissions(with NAVIGATION AppService permissions to handle rpc SendLocation) are assigned for <app1ID> |
There was a problem hiding this comment.
Suggested change
| -- 2) AppServiceProvider permissions(with NAVIGATION AppService permissions to handle rpc SendLocation) are assigned for <app1ID> | |
| -- 2) AppServiceProvider permissions(with NAVIGATION AppService permissions to handle rpc FutureRequest) are assigned for <app1ID> |
| -- Precondition: | ||
| -- 1) app1, app2 and app3 are registered on SDL. | ||
| -- 2) AppServiceProvider permissions(with NAVIGATION AppService permissions to handle rpc SendLocation) are assigned for <app1ID> | ||
| -- 3) AppServiceProvider permissions(with MEDIA AppService permissions to handle rpc SendLocation) are assigned for <app2ID> |
There was a problem hiding this comment.
Suggested change
| -- 3) AppServiceProvider permissions(with MEDIA AppService permissions to handle rpc SendLocation) are assigned for <app2ID> | |
| -- 3) AppServiceProvider permissions(with MEDIA AppService permissions to handle rpc FutureRequest) are assigned for <app2ID> |
| -- 2) AppServiceProvider permissions(with NAVIGATION AppService permissions to handle rpc SendLocation) are assigned for <app1ID> | ||
| -- 3) AppServiceProvider permissions(with MEDIA AppService permissions to handle rpc SendLocation) are assigned for <app2ID> | ||
| -- 4) Base-4 permissions are assigned for <app3ID> | ||
| -- 5) pt_entry.allow_unknown_rpc_passthrough = false policy assigned for <app3ID> |
There was a problem hiding this comment.
Suggested change
| -- 5) pt_entry.allow_unknown_rpc_passthrough = false policy assigned for <app3ID> | |
| -- 5) allow_unknown_rpc_passthrough = false policy assigned for <app3ID> |
| -- 3) AppServiceProvider permissions(with MEDIA AppService permissions to handle rpc SendLocation) are assigned for <app2ID> | ||
| -- 4) Base-4 permissions are assigned for <app3ID> | ||
| -- 5) pt_entry.allow_unknown_rpc_passthrough = false policy assigned for <app3ID> | ||
| -- 6) app1 sends a PublishAppService (with {serviceType=NAVIGATION, handledRPC=SendLocation} in the manifest) |
There was a problem hiding this comment.
Suggested change
| -- 6) app1 sends a PublishAppService (with {serviceType=NAVIGATION, handledRPC=SendLocation} in the manifest) | |
| -- 6) app1 sends a PublishAppService (with {serviceType=NAVIGATION, handledRPC=FutureRequest} in the manifest) |
| -- 4) Base-4 permissions are assigned for <app3ID> | ||
| -- 5) pt_entry.allow_unknown_rpc_passthrough = false policy assigned for <app3ID> | ||
| -- 6) app1 sends a PublishAppService (with {serviceType=NAVIGATION, handledRPC=SendLocation} in the manifest) | ||
| -- 7) app2 sends a PublishAppService (with {serviceType=MEDIA, handledRPC=SendLocation} in the manifest) |
There was a problem hiding this comment.
Suggested change
| -- 7) app2 sends a PublishAppService (with {serviceType=MEDIA, handledRPC=SendLocation} in the manifest) | |
| -- 7) app2 sends a PublishAppService (with {serviceType=MEDIA, handledRPC=FutureRequest} in the manifest) |
| local manifest2 = { | ||
| serviceName = config.application2.registerAppInterfaceParams.appName, | ||
| serviceType = "MEDIA", | ||
| handledRPCs = { 109 }, |
There was a problem hiding this comment.
Suggested change
| handledRPCs = { 109 }, | |
| handledRPCs = { rpcRequest.funcId }, |
| local manifest = { | ||
| serviceName = config.application1.registerAppInterfaceParams.appName, | ||
| serviceType = "NAVIGATION", | ||
| handledRPCs = { 109 }, |
There was a problem hiding this comment.
Suggested change
| handledRPCs = { 109 }, | |
| handledRPCs = { rpcRequest.funcId }, |
| local function PTUfunc(tbl) | ||
| --Add permissions for app1 | ||
| local pt_entry = common.getAppServiceProducerConfig(1) | ||
| pt_entry.app_services.NAVIGATION = { handled_rpcs = {{function_id = 109}} } |
There was a problem hiding this comment.
Suggested change
| pt_entry.app_services.NAVIGATION = { handled_rpcs = {{function_id = 109}} } | |
| pt_entry.app_services.NAVIGATION = { handled_rpcs = {{function_id = rpcRequest.funcId}} } |
| tbl.policy_table.app_policies[common.getConfigAppParams(1).fullAppID] = pt_entry | ||
| --Add permissions for app2 | ||
| pt_entry = common.getAppServiceProducerConfig(2) | ||
| pt_entry.app_services.MEDIA.handled_rpcs = {{function_id = 109}} |
There was a problem hiding this comment.
Suggested change
| pt_entry.app_services.MEDIA.handled_rpcs = {{function_id = 109}} | |
| pt_entry.app_services.MEDIA.handled_rpcs = {{function_id = rpcRequest.funcId}} |
| @@ -0,0 +1,126 @@ | |||
| --------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Perhaps rename the file to indicate that allow_unknown_rpc_passthrough had been set to false. Maybe something like 009_UnknownRPC_Passthrough_Disallowed
jacobkeeler
reviewed
Apr 11, 2019
| @@ -0,0 +1,126 @@ | |||
| --------------------------------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
This is an outdated version of one of my tests: https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2188/files#diff-a0d996330af833ecde62a2071206c093
There was a problem hiding this comment.
I see how it is different, using allow_unknown_rpc_passthrough as false. Still, I might suggest using the latest version of https://github.com/smartdevicelink/sdl_atf_test_scripts/pull/2188/files#diff-aecc1389162e76ba570ab26084cb9d94 as a base for this.
jacobkeeler
reviewed
Apr 11, 2019
...vices/RPCPassThrough/009_UnknownRPC_Consumer_UNSUPPORTED_REQUEST_policy_allow_flag_false.lua
Outdated
Show resolved
Hide resolved
…r_UNSUPPORTED_REQUEST_policy_allow_flag_false.lua Co-Authored-By: JackLivio <jack@livio.io>
ShobhitAd
requested changes
Apr 11, 2019
...vices/RPCPassThrough/009_UnknownRPC_Consumer_UNSUPPORTED_REQUEST_policy_allow_flag_false.lua
Outdated
Show resolved
Hide resolved
| -- | ||
| -- Expected: | ||
| -- 1) Core does not forward the request to any provider application | ||
| -- 2) core responds to app3 with { success = false, resultCode = "UNSUPPORTED_REQUEST" } |
There was a problem hiding this comment.
Suggested change
| -- 2) core responds to app3 with { success = false, resultCode = "UNSUPPORTED_REQUEST" } | |
| -- 2) Core responds to app3 with { success = false, resultCode = "UNSUPPORTED_REQUEST" } |
…r_UNSUPPORTED_REQUEST_policy_allow_flag_false.lua Co-Authored-By: JackLivio <jack@livio.io>
ShobhitAd
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review.
Summary
Add tests for app policy field
allow_unknown_rpc_passthroughWIP, more tests being added
CLA