Skip to content

rename svm svr to svc in tests and docs #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

z1queue
Copy link
Contributor

@z1queue z1queue commented Feb 25, 2021

No description provided.

@VolodymyrOrlov
Copy link
Collaborator

Hi @z1queue, thanks for noticing it! Looks like your fork is 96 commits behind smartcorelib:development. Could you please pull the latest changes into your fork? This should fix Clippy errors you get in your PR.

@codecov-io
Copy link

Codecov Report

Merging #83 (6d58dbe) into development (1b42f8a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development      #83      +/-   ##
===============================================
+ Coverage        84.21%   84.26%   +0.04%     
===============================================
  Files               78       78              
  Lines             8250     8250              
===============================================
+ Hits              6948     6952       +4     
+ Misses            1302     1298       -4     
Impacted Files Coverage Δ
src/svm/svc.rs 89.62% <100.00%> (ø)
src/optimization/line_search.rs 90.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b42f8a...6d58dbe. Read the comment docs.

@VolodymyrOrlov VolodymyrOrlov self-requested a review February 26, 2021 02:56
Copy link
Collaborator

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @z1queue!

@VolodymyrOrlov VolodymyrOrlov merged commit a920959 into smartcorelib:development Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants