Skip to content

fix needless-range and clippy::ptr_arg warnings. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 11, 2020
Merged

fix needless-range and clippy::ptr_arg warnings. #36

merged 2 commits into from
Dec 11, 2020

Conversation

morenol
Copy link
Collaborator

@morenol morenol commented Dec 11, 2020 •
edited
Loading

clippy::ptr_arg is still present in:

  • src/algorithm/neighbour/mod.rs
  • src/metrics/cluster_helpers.rs
  • src/linalg/naive/dense_matrix.rs

Not sure how to fix that warning in those files.

Closes #22

VolodymyrOrlov
VolodymyrOrlov approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@VolodymyrOrlov VolodymyrOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VolodymyrOrlov VolodymyrOrlov self-requested a review December 11, 2020 20:37
VolodymyrOrlov
VolodymyrOrlov previously approved these changes Dec 11, 2020
View reviewed changes
@morenol
Copy link
Collaborator Author

morenol commented Dec 11, 2020

I am sorry @VolodymyrOrlov, I force pushed for a change in a variable name in the first commit.

VolodymyrOrlov
VolodymyrOrlov approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@VolodymyrOrlov VolodymyrOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem!

@morenol morenol merged commit 53351b2 into smartcorelib:development Dec 11, 2020
@morenol morenol deleted the lmm/clippy branch April 28, 2021 16:34
@morenol morenol restored the lmm/clippy branch April 28, 2021 16:34
@morenol morenol deleted the lmm/clippy branch May 5, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VolodymyrOrlov VolodymyrOrlov VolodymyrOrlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cargo clippy checks
2 participants
@morenol @VolodymyrOrlov