Open
Conversation
Collaborator
|
thanks. i will review this as soon as possible |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #358 +/- ##
===============================================
- Coverage 45.59% 44.29% -1.31%
===============================================
Files 93 95 +2
Lines 8034 7997 -37
===============================================
- Hits 3663 3542 -121
- Misses 4371 4455 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys!
My first PR to your library. I added Jaccard distance. Everything is done carefully in accordance to the best development practices.
Checklist
Current behaviour
there is no jaccard distance!
New expected behaviour
now there IS the jaccard distance functionality in the library. Done with respect to the current API, and checked using a smass binary outside of the code.
Change logs
Added
Jaccard distance