Skip to content

Port num.rs from #108 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2022
Merged

Port num.rs from #108 #173

merged 1 commit into from
Oct 6, 2022

Conversation

Mec-iS
Copy link
Collaborator

@Mec-iS Mec-iS commented Sep 23, 2022 •
edited
Loading

I will add the "Authored" annotations at merge to assign the right credit to Volodymyr

Please provide a road map suggesting how to proceed next. Which modules are ready to be ported?

@Mec-iS Mec-iS mentioned this pull request Sep 23, 2022
Merged
montanalow
montanalow reviewed Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@montanalow montanalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I'm familiar enough with the usage of these primitives throughout SmartCore to effectively review and see issues that would arise.

@Mec-iS Mec-iS changed the base branch from development to merge-numtraits October 6, 2022 09:08
@Mec-iS
Copy link
Collaborator Author

Mec-iS commented Oct 6, 2022

I created a new branch where to proceed with the merging of the new code with the new num-traits implementation.

@Mec-iS Mec-iS merged commit 3cf80d7 into merge-numtraits Oct 6, 2022
@Mec-iS Mec-iS deleted the implement-num-rs branch October 6, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montanalow montanalow montanalow left review comments

@morenol morenol Awaiting requested review from morenol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mec-iS @montanalow