This repository was archived by the owner on Sep 5, 2024. It is now read-only.
[TT-1306] better contract deployer #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it (can provide extra info if constructor calls other functions)
kalverra
approved these changes
Jun 25, 2024
skudasov
reviewed
Jun 25, 2024
| }), | ||
| ); err != nil { | ||
| // do not pass the error here, because it's not transaction submission error | ||
| _, _ = m.Decode(tx, nil) |
Collaborator
There was a problem hiding this comment.
Can we still use errors.Wrap()? Can it indicate both that we failed to wait for the deployed contract to appear on the chain and that we failed to decode the transaction?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slightly modified function call in contract deployment + try to decode it (can provide extra info if constructor calls other functions)