Skip to content

Update dependency eventsource from 2.0.2 to 4.0.0 and remove @types/eventsource #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

dskloetc
Copy link
Contributor

@dskloetc dskloetc commented May 19, 2025

Description

The renovate PR to update @types/eventsource to v3 had failures.
While investigating I found that @types/eventsource was removed because the types are included in eventsource starting from version 3.0.0.

Changes

  1. Ran yarn remove @types/eventsource.
  2. Ran yarn add eventsource.
  3. Fixed import statements.
  4. Changed EventSource.EventSourceInitDict to EventSourceInit
  5. Removed ^ from version after pinned-dependencies.yaml failed.

@dskloetc dskloetc added the none label May 19, 2025
Copy link
Contributor

github-actions bot commented May 19, 2025

NPM Publishing labels 🏷️

🔵 This PR has the none label set and it will not cause a version bump.

@dskloetc dskloetc marked this pull request as ready for review May 19, 2025 09:50
@dskloetc dskloetc requested a review from a team as a code owner May 19, 2025 09:50
@mxiao-cll
Copy link
Contributor

Is this a breaking change? There is one EA using this in the main repo. Can we test it locally to see if that EA is impacted?

If impacted we need to mark this as a major and make changes on EA accordingly

(I am asking because when I tried to do the v3 upgrade it is breaking the main EA)

@dskloetc
Copy link
Contributor Author

I looked but I couldn't find any EA using this. I searched for SseTransport. The only thing I found was oanda but it creates ModifiedSseTransport which is not related to SseTransport.

Which EA is using this and how did it break for you?

@dskloetc dskloetc requested a review from mxiao-cll May 20, 2025 07:16
@mxiao-cll
Copy link
Contributor

Yes that oanda EA, I don't quite remember the details but I think it was some types breaking. As long as we can confirm oanda is still good we should be good.

@dskloetc
Copy link
Contributor Author

I did test Oanda with the framework changes and it appeared unaffected.

@dskloetc dskloetc merged commit 60f68f7 into main May 20, 2025
12 checks passed
Copy link
Contributor

❌ failed to create version bump PR
Failure message: No message provided
Failed job: createVersionBumpPR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants