Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/chains: simplify nodes #8889

Merged
merged 4 commits into from
Apr 5, 2023
Merged

core/chains: simplify nodes #8889

merged 4 commits into from
Apr 5, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Mar 31, 2023

This is part legacy config cleanup (like #8830) and also working towards https://smartcontract-it.atlassian.net/browse/BCF-2114.

  • TOML node config w/ general type NodeStatus
  • less generics mess
  • chain-agnostic NodeStatuses

@github-actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the nodes-config-simplify branch 12 times, most recently from 4156a9b to 97a53a3 Compare April 1, 2023 00:24
@jmank88 jmank88 marked this pull request as ready for review April 1, 2023 00:44
@jmank88 jmank88 force-pushed the nodes-config-simplify branch 5 times, most recently from bfc3069 to c796b92 Compare April 3, 2023 13:18
@jmank88 jmank88 force-pushed the nodes-config-simplify branch from c796b92 to 66a77d5 Compare April 4, 2023 11:20
@jmank88 jmank88 requested a review from aalu1418 April 4, 2023 21:27
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 64.6% 64.6% Coverage on New Code (is less than 80%)
Failed condition 4.7% 4.68% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@jmank88 jmank88 merged commit de27853 into develop Apr 5, 2023
@jmank88 jmank88 deleted the nodes-config-simplify branch April 5, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants