Use reflection to generate config whitelist from actual config #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out this code was full of copy and paste glitches. Since this should ultimately represent a subset of the complete Config, I decided to fix this issue once and for all with reflection. Incorrect outputs were: 1. TX_MIN_CONFIRMATIONS 2. TASK_MIN_CONFIRMATIONS 3. DATABASE_POLL_INTERVAL
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
## Motivation To help multiple cases in CCIP-2049 where we expect failures at different parts of CCIP lifecycle. ## Solution Make `ValidateRequests` more flexible on what it is able to consider "Valid" ```go // Old usage, could only check for specific failures of `ExecStateChanged` // Should pass tc.lane.ValidateRequests(true) // Should fail tc.lane.ValidateRequests(false) // New usage, can specify phase, error, and existence // Should pass tc.lane.ValidateRequests() // Should fail tc.lane.ValidateRequests(ExpectPhaseToFail(ExecStateChanged, ShouldExist())) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out this code was full of copy and paste glitches. Since this
should ultimately represent a subset of the complete Config, I decided
to fix this issue once and for all with reflection.
Incorrect outputs were: