Fix fromBlock validation in lp replay #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
connorwstein
commented
Sep 27, 2022
•
connorwstein
commented
- When replaying we need to take min(latest, fromBlock) once the replay select case has been selected to avoid skipping blocks. Fixes problematic replays which have fromBlock in (latestBlock, chainHead).
- Exposing lp test harness for use in both black and whitebox test (removes some boilerplate)
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
makramkd
reviewed
Sep 27, 2022
jmank88
approved these changes
Sep 28, 2022
makramkd
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.