Refactor forwarders naming #7197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
essamhassan
force-pushed
the
chore/forwarder-cli-track
branch
from
b095b85
to
66c9213
Compare
essamhassan
force-pushed
the
chore/forwarder-cli-track
branch
from
66c9213
to
82b6eef
Compare
essamhassan
changed the title
essamhassan
force-pushed
the
chore/forwarder-cli-track
branch
2 times, most recently
from
9b99e57
to
f48309d
Compare
jmank88
previously approved these changes
Aug 9, 2022
essamhassan
force-pushed
the
chore/forwarder-cli-track
branch
from
f48309d
to
f94547d
Compare
essamhassan
force-pushed
the
chore/forwarder-cli-track
branch
from
f94547d
to
3c3a1f1
Compare
jmank88
approved these changes
Aug 9, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might potentially need to have a separate create that deploys the forwarder on chain. Renaming now ahead of release makes it easier to implement that in the future.