Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/utils: add Wei.String() #7156

Merged
merged 2 commits into from
Aug 4, 2022
Merged

core/utils: add Wei.String() #7156

merged 2 commits into from
Aug 4, 2022

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Aug 4, 2022

Add utils#Wei.String(), and use it to implement MarshalText().

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Solana Smoke Test Results

1 tests   1 ✔️  4m 27s ⏱️
1 suites  0 💤
1 files    0

Results for commit 1406520.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

EVM Smoke Test Results

52 tests   22 ✔️  6m 16s ⏱️
  1 suites  30 💤
  1 files      0

Results for commit 1406520.

♻️ This comment has been updated with latest results.

@jmank88 jmank88 marked this pull request as ready for review August 4, 2022 18:13
Copy link
Contributor

@essamhassan essamhassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, LGTM

@jmank88 jmank88 merged commit def8623 into develop Aug 4, 2022
@jmank88 jmank88 deleted the wei-string branch August 4, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants