Update log/pool.go & log/pool_test.go for besu #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests for addLog and added some new ones
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
pinebit
approved these changes
Jul 29, 2022
jmank88
approved these changes
Jul 29, 2022
vyzaldysanchez
approved these changes
Jul 29, 2022
samsondav
approved these changes
Jul 29, 2022
reductionista
added a commit
that referenced
this pull request
Jul 29, 2022
Updated tests for addLog and added some new ones
samsondav
added a commit
that referenced
this pull request
Jul 29, 2022
Update log/pool.go & log/pool_test.go for besu (#7106)
reductionista
added a commit
that referenced
this pull request
Aug 4, 2022
This reverts commit 4944ded.
This was referenced Aug 9, 2022
github-actions bot
pushed a commit
to 0xsnowya/chainlink
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #7072. This updates the log pool with the same change which was made for logBroadcaster and VRF (add TxIndex in case LogIndex is not unique enough to distinguish different logs from duplicates).
Also update tests for addLog, and add some new ones including attempt to add a duplicate.