gas limit is uint32 everywhere #7012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
pinebit
requested review from
samsondav,
jmank88,
jkongie,
connorwstein,
makramkd,
spooktheducks,
prashantkumar1982,
a team and
PiotrTrzpil
as code owners
jmank88
previously approved these changes
Jul 22, 2022
samsondav
previously approved these changes
Aug 5, 2022
jmank88
previously approved these changes
Aug 5, 2022
jmank88
approved these changes
Aug 8, 2022
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samsondav @jmank88 do you guys think this change makes sense or not?
The reason behind this is that we can only read uint32 from TOML and therefore I assumed it makes little sense to do odd type conversions uint32<->uint64 for gas limit. However, we still have to do the conversion when dealing with go-ethereum.