Feature/cre aptos v2.35.0 by cawthorne · Pull Request #21321 · smartcontractkit/chainlink

cawthorne · 2026-02-27T02:24:46Z

This is currently a proof of concept demo, not an intention to merge.

Code quality and conventions need combing through.

core/capabilities/remote/executable/request/client_request.go

Tofel · 2026-02-27T11:01:56Z

core/scripts/cre/environment/environment/environment.go

+
+// ensureLocalDepsDockerignore writes a temporary .dockerignore in parentDir so the Docker build
+// context includes only chainlink, chainlink-common, capabilities, and optionally chainlink-aptos
+// (avoids sending the entire parent dir, e.g. 22GB+ and I/O errors). Caller must run the returned cleanup.


curious about this... I had the same problem, it should be fixed now that I added .git to the main .dockerignore. Can you check if yours contains .git?

Tofel · 2026-02-27T11:02:26Z

core/scripts/cre/environment/environment/environment.go

+
+// ensureLocalDepsNodeImage builds the chainlink node image when node specs use docker_file and
+// docker_ctx for the local-deps Dockerfile (context ".."). The framework corrupts absolute paths
+// (e.g. produces "../Users"), so we build the image ourselves with correct paths and then set


could you expand on that?

Tofel · 2026-02-27T11:03:56Z

core/scripts/cre/environment/environment/environment.go

+		}
+		fmt.Print(libformat.PurpleText("\tCapabilities: %s\n", capabilitiesDesc))
+		fmt.Print(libformat.PurpleText("\tDON Types: %s\n\n", strings.Join(nodeSet.DONTypes, ", ")))
+	}


why do we need that if we have this?

DONs +-------------------+-------------------+-------+------------+---------------------+ | DON | Types | Nodes | EVM Chains | Attributes | +-------------------+-------------------+-------+------------+---------------------+ | bootstrap-gateway | bootstrap,gateway | 1 | 1337, 2337 | - | | capabilities | capabilities | 4 | 1337, 2337 | remote-capabilities | | workflow | workflow | 4 | 1337, 2337 | - | +-------------------+-------------------+-------+------------+---------------------+ Capability Matrix +-----------------+-------------------+-----------------------+--------------+ | Capability | bootstrap-gateway | capabilities | workflow | +-----------------+-------------------+-----------------------+--------------+ | consensus | - | - | local | | cron | - | - | local | | custom-compute | - | - | local | | don-time | - | - | local | | evm | - | remote-exposed (2337) | local (1337) | | http-action | - | - | local | | http-trigger | - | - | local | | ocr3 | - | - | local | | read-contract | - | remote-exposed (2337) | local (1337) | | vault | - | remote-exposed | - | | web-api-target | - | remote-exposed | - | | web-api-trigger | - | - | local | | write-evm | - | remote-exposed (2337) | local (1337) |

Tofel · 2026-02-27T11:06:26Z

core/scripts/cre/environment/environment/environment.go

 		Features:                features,
 		GatewayWhitelistConfig:  gatewayWhitelistConfig,
 		BlockchainDeployers:     blockchains_sets.NewDeployerSet(testLogger, in.Infra),
+		AptosForwarderAddresses: in.AptosForwarderAddresses,


where does this come from? any reason for passing it here instead of deploying it in pre/post startup hook? or if this is some static value per chainID you could pass it via capabilities values as map of map[chainID]address.

Tofel · 2026-02-27T11:07:04Z

core/scripts/cre/environment/environment/setup.go

+			return "", fmt.Errorf("failed to resolve docker context path: %w", err)
+		}
+	}
+	args := []string{"build", "-t", c.LocalImage, "-f", dockerfilePath, ctxPath}


I understand this is a temporary helper?

Tofel · 2026-02-27T11:07:46Z

core/scripts/cre/environment/fast_aptos_tdd.sh

+for target in "$@"; do
+  run_target "$target"
+done
+


is this file a temporary helper? if not, I think this should go GNUMakefile

Tofel · 2026-02-27T11:08:59Z

core/scripts/go.mod

-require (
-	github.com/smartcontractkit/chainlink/deployment v0.0.0-20251021194914-c0e3fec1a97c
-	github.com/smartcontractkit/chainlink/v2 v2.32.0
-)


Tofel · 2026-02-27T11:10:01Z

plugins/plugins.public.yaml

@@ -10,21 +10,19 @@ defaults:
 plugins:
  aptos:
    - moduleURI: "github.com/smartcontractkit/chainlink-aptos"
-      gitRef: "v0.0.0-20260217195306-9fec97c5dfbd"
+      gitRef: "v0.0.0-20260226223744-e59e9b1ad93f"


what's the diff between that public and private plugin?

Tofel · 2026-02-27T11:12:04Z

system-tests/lib/cre/don/config/config.go

+			"Workflow": map[string]any{"ForwarderAddress": ac.ForwarderAddress},
+			"Nodes":    []map[string]any{{"Name": "default", "URL": ac.NodeURL}},
+		})
+	}


I think this should be done in features/aptos... the reason we have EVM here is that it is required for node to function, but aptos is optional and dependent on whether a DON has this capability or not

Tofel · 2026-02-27T11:15:05Z

system-tests/lib/cre/environment/config/config.go

@@ -65,7 +65,9 @@ type Config struct {
 	FakeHTTP          *fake.Input                     `toml:"fake_http" validate:"required"`
 	S3ProviderInput   *s3provider.Input               `toml:"s3provider"`
 	CapabilityConfigs map[string]cre.CapabilityConfig `toml:"capability_configs"` // capability flag -> capability config
-	Addresses         []string                        `toml:"addresses"`
+	// Optional map of Aptos chain selector -> forwarder address used for Aptos write capability runtime config.
+	AptosForwarderAddresses map[uint64]string `toml:"aptos_forwarder_addresses"`


this should go to the default aptos capability config toml

Tofel · 2026-02-27T11:18:14Z

system-tests/lib/cre/environment/environment.go

+	}
+
+	return nil
+}


all of that code should go to features/aptos, it deffo doesn't belong here

Tofel · 2026-02-27T11:19:29Z

system-tests/lib/cre/environment/environment.go

+	// the Capability Registry (required for Aptos and other topologies where nodes have multiple chains).
+	if waitErr := waitForWorkflowNodesEVMChainConfig(ctx, deployKeystoneContractsOutput.Env.Offchain, dons, testLogger); waitErr != nil {
+		return nil, pkgerrors.Wrap(waitErr, "failed waiting for workflow nodes to register EVM chain config with Job Distributor")
+	}


why is this needed? once nodes are registered with JD this must be true... afaik this is not an async operation.

Tofel · 2026-02-27T11:19:40Z

system-tests/lib/cre/environment/environment.go

+		aptosForwarderAddresses,
+	); cfgErr != nil {
+		return nil, fmt.Errorf("failed to configure Aptos forwarders: %w", cfgErr)
+	}


features/aptos

Tofel · 2026-02-27T11:21:04Z

system-tests/lib/cre/features/vault/vault.go

sure we don't need it any more?

I think this was a git merge error. Will revert. I did not intend to touch this code.

Tofel · 2026-02-27T11:21:51Z

system-tests/lib/cre/don.go

-			return fmt.Errorf("no OCR2 key bundle id found for node %s", n.Name)
+			// Best-effort self-heal: create missing OCR2 key bundle for this chain type,
+			// then re-fetch the bundle ID from GraphQL.
+			if n.Clients.RestClient == nil {


why is the bundle be missing in the first place?

Tofel · 2026-02-27T11:22:52Z

system-tests/lib/cre/types.go

@@ -1264,6 +1272,11 @@ func (c *NodeSet) chainCapabilityIDs() []uint64 {
 	return out
 }

+// ChainCapabilityChainIDs returns the set of chain IDs supported by this node set's chain-scoped capabilities (e.g. read-contract-4, write-aptos-4).
+func (c *NodeSet) ChainCapabilityChainIDs() []uint64 {
+	return c.chainCapabilityIDs()


why not make it public instead?

Tofel · 2026-02-27T11:24:05Z

system-tests/tests/smoke/cre/cre_suite_test.go

+	t.Run("[v2] Aptos Write Expected Failure", func(t *testing.T) {
+		ExecuteAptosWriteExpectedFailureOnlyTest(t, testEnv)
+	})
+}


in the final version we'd probably only want to keep roundtrip + failure so that execution time in CI doesn't explode, would that be possible?

Can do yeah.

Tofel · 2026-02-27T11:24:44Z

system-tests/tests/smoke/cre/v2_aptos_capability_test.go

+	userLogsCh := make(chan *workflowevents.UserLogs, 1000)
+	baseMessageCh := make(chan *commonevents.BaseMessage, 1000)
+
+	server := t_helpers.StartChipTestSink(t, t_helpers.GetLoggingPublishFn(lggr, userLogsCh, baseMessageCh, "./logs/aptos_capability_workflow_test.log"))


Tofel · 2026-02-27T11:25:30Z

system-tests/tests/smoke/cre/v2_sharding_test.go

…sh validation

… default

github-actions · 2026-02-27T20:59:14Z

CORA - Pending Reviewers

Codeowners Entry	Overall	Num Files	Owners
`*`	❌	35	@smartcontractkit/foundations, @smartcontractkit/core
`/core/capabilities/`	❌	4	@smartcontractkit/keystone, @smartcontractkit/capabilities-team
`/core/services/workflows`	❌	1	@smartcontractkit/keystone
`/core/services/standardcapabilities`	❌	2	@smartcontractkit/keystone
`/deployment/cre`	❌	2	@smartcontractkit/keystone, @smartcontractkit/operations-platform
`/core/chainlink.Dockerfile`	❌	1	@smartcontractkit/devex-cicd, @smartcontractkit/foundations, @smartcontractkit/core
`go.mod`	❌	7	@smartcontractkit/core, @smartcontractkit/foundations
`go.sum`	❌	7	@smartcontractkit/core, @smartcontractkit/foundations

For more details, see the full review summary.

github-actions · 2026-02-27T20:59:53Z

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

#added For any new functionality added.
#breaking_change For any functionality that requires manual action for the node to boot.
#bugfix For bug fixes.
#changed For any change to the existing functionality.
#db_update For any feature that introduces updates to database schema.
#deprecation_notice For any upcoming deprecation functionality.
#internal For changesets that need to be excluded from the final changelog.
#nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
#removed For any functionality/config that is removed.
#updated For any functionality that is updated.
#wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

github-actions · 2026-02-27T21:00:22Z

✅ No conflicts with other open PRs targeting develop

cl-sonarqube-production · 2026-02-27T21:20:58Z

Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarQube

trunk-io · 2026-02-27T23:19:02Z

Failed Test	Failure Summary	Logs
`Test_CRE_V2_Aptos_Write`		Logs ↗︎
`Test_CRE_V2_Aptos_Suite/[v2]_Aptos`		Logs ↗︎
`Test_CRE_V2_Aptos_Write_Expected_Failure`		Logs ↗︎
`Test_CRE_V2_Aptos_Write_Read_Roundtrip`		Logs ↗︎

... and 6 more

View Full Report ↗︎ ⋅ Docs

bolekk requested changes Feb 27, 2026

View reviewed changes

core/capabilities/remote/executable/request/client_request.go Outdated Show resolved Hide resolved

Tofel reviewed Feb 27, 2026

View reviewed changes

system-tests/tests/smoke/cre/v2_sharding_test.go

Copy link

Contributor

Tofel Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cawthorne changed the base branch from develop to release/2.35.0 February 27, 2026 14:17

cawthorne changed the base branch from release/2.35.0 to develop February 27, 2026 14:19

cawthorne added 4 commits February 27, 2026 17:34

cre aptos: add read/write capabilities and local CRE suite with tx-ha…

3b39d45

…sh validation

aptos write policy: support both tx-hash proto variants after rebase

0f50040

cre env: avoid root go mod tidy in run_aptos_full

e8a6f2f

fix(cre): preserve local capabilities config and keep job-spec launch…

e5e9956

… default

cawthorne force-pushed the feature/cre-aptos-v2.35.0 branch from 0d6ee82 to e5e9956 Compare February 27, 2026 20:58

Conversation

cawthorne commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 27, 2026

CORA - Pending Reviewers

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

cl-sonarqube-production bot commented Feb 27, 2026

Quality Gate failed

Uh oh!

trunk-io bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cawthorne commented Feb 27, 2026 •

edited

Loading